Fix Callable::from_sync_fn doc example using deprecated Result<T> return
#1347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arocull
changed the title
arocull
changed the title
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1347 |
arocull
force-pushed
the
fix-callable-from-sync-fn-docs
branch
from
cd8b3e4 to
68fa5af
Compare
|
Looks good to me; Could you please rebase on the latest master? The previous run failed due to change in Godot 4.6 API (#1349). |
arocull
force-pushed
the
fix-callable-from-sync-fn-docs
branch
from
68fa5af to
11cf84d
Compare
Yarwin
reviewed
Oct 2, 2025
arocull
force-pushed
the
fix-callable-from-sync-fn-docs
branch
from
11cf84d to
3b92998
Compare
Yarwin
approved these changes
Oct 3, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Why did incorrect doctests pass in CI? It looks like they aren't compiled. |
Bromeon
added
bug
documentation
Bromeon
changed the title
Callable::from_sync_fn doc example using deprecated Result<T> return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the migration guide, Callable return types do not use a result anymore. I got caught on this example while migrating this function.
Not sure if I should shorten the return value to a single line, or keep the type verbose for clarity.
Additionally fixes docs as pointed out by Pspritechologist in the Discord